[
https://issues.apache.org/jira/browse/HADOOP-15675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16584268#comment-16584268
]
Allen Wittenauer commented on HADOOP-15675:
-------------------------------------------
While working with YETUS-660, it's become evident that the strategy of bundling
the checkstyle suppressions file into the hadoop-build-tools jar makes it
extremely likely that checkstyle changes will get missed during a build. I
believe I have a way to mitigate it during precommit, but as it stands,
individual users are *very likely* to have problems.
> checkstyle suppressions files are cached
> ----------------------------------------
>
> Key: HADOOP-15675
> URL: https://issues.apache.org/jira/browse/HADOOP-15675
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Reporter: Kitti Nanasi
> Priority: Minor
>
> If a patch is created with checkstyle errors, for example when a modified
> line is longer than 80 characters, then running checkstyle with the
> test-patch script runs to success (though it should fail and show an error
> about the long line).
> {code:java}
> dev-support/bin/test-patch --plugins="-checkstyle" test.patch{code}
> However it does show the error (so works correctly) when running it with the
> IDEA checkstyle plugin.
>
> I only tried it out it for patches with too long lines and wrong indentation,
> but I assume that it can be a more general problem.
> We realised this when reviewing HDFS-13217, where patch 004 has a "too long
> line" checkstyle error. In the first build for that patch, the checkstyle
> report was showing the error, but when it was ran again with the same patch,
> the error disappeared. So probably the checkstyle checking stopped working on
> trunk somewhere between April and July 2018.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
