[
https://issues.apache.org/jira/browse/HADOOP-7342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13041967#comment-13041967
]
Konstantin Boudnik commented on HADOOP-7342:
--------------------------------------------
Coupla comments Bharath:
- this sounds like you are trying to use exceptions to replace return value
checks. Now you'd have to check IOException around all the calls to the new
API. Besides, you're kinda violating original {{File.list()}} contract which
doesn't declare IOException
Also, asserts in the tests are better to have messages to ease detection of
test failures
> Add an utility API in FileUtil for JDK File.list
> ------------------------------------------------
>
> Key: HADOOP-7342
> URL: https://issues.apache.org/jira/browse/HADOOP-7342
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.23.0
> Reporter: Bharath Mundlapudi
> Assignee: Bharath Mundlapudi
> Priority: Minor
> Fix For: 0.23.0
>
> Attachments: HADOOP-7342-1.patch
>
>
> Java File.list API can return null when disk is bad or directory is not a
> directory. This utility API in FileUtil will throw an exception when this
> happens rather than returning null.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
