[ 
https://issues.apache.org/jira/browse/HADOOP-15698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16595579#comment-16595579
 ] 

Xiao Chen commented on HADOOP-15698:
------------------------------------

Thanks Kitti for working on this, good find! Also thanks Ajay for the comment.

+1 on patch 1. Thanks Ajay for bringing up the testing idea, and I agree we 
want tests with a fix in general. Giving the static initialization of things, 
IMO this fix can go with just the manual testing. I tried locally and can see 
the logs after a kms startup. Also good to know that Kitti tested this in a 
cluster where the issue was occurring before and fixed after.

 

If no more concerns I plan to commit this by end of Wednesday.

> KMS startup logs don't show
> ---------------------------
>
>                 Key: HADOOP-15698
>                 URL: https://issues.apache.org/jira/browse/HADOOP-15698
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: kms
>    Affects Versions: 3.1.0
>            Reporter: Kitti Nanasi
>            Assignee: Kitti Nanasi
>            Priority: Major
>         Attachments: HADOOP-15698.001.patch
>
>
> During KMs startup, log4j logs don't show up resulting in important logs 
> getting omitted. This happens because log4 initialisation only happens in 
> KMSWebApp#contextInitialized and logs written before that don't show up.
> For example the following log never shows up:
> [https://github.com/apache/hadoop/blob/a55d6bba71c81c1c4e9d8cd11f55c78f10a548b0/hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/util/ZKSignerSecretProvider.java#L197-L199]
> Another example is that the KMS startup message never shows up in the kms 
> logs.
> Note that this works in the unit tests, because MiniKMS sets the log4j system 
> property.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to