[
https://issues.apache.org/jira/browse/HADOOP-14833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16598505#comment-16598505
]
Steve Loughran commented on HADOOP-14833:
-----------------------------------------
checkstyles
{code}
./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/SimpleAWSCredentialsProvider.java:30:import
org.apache.hadoop.security.ProviderUtils;:8: Unused import -
org.apache.hadoop.security.ProviderUtils. [UnusedImports]
./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/SimpleAWSCredentialsProvider.java:35:import
static org.apache.hadoop.fs.s3a.Constants.ACCESS_KEY;:15: Unused import -
org.apache.hadoop.fs.s3a.Constants.ACCESS_KEY. [UnusedImports]
./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/SimpleAWSCredentialsProvider.java:36:import
static org.apache.hadoop.fs.s3a.Constants.SECRET_KEY;:15: Unused import -
org.apache.hadoop.fs.s3a.Constants.SECRET_KEY. [UnusedImports]
./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/SimpleAWSCredentialsProvider.java:58:
S3xLoginHelper.Login login = getAWSAccessKeys(uri, conf);: 'ctor def'
child has incorrect indentation level 6, expected level should be 4.
[Indentation]
./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/SimpleAWSCredentialsProvider.java:59:
this.accessKey = login.getUser();: 'ctor def' child has incorrect
indentation level 6, expected level should be 4. [Indentation]
./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/SimpleAWSCredentialsProvider.java:60:
this.secretKey = login.getPassword();: 'ctor def' child has incorrect
indentation level 6, expected level should be 4. [Indentation]
./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/TemporaryAWSCredentialsProvider.java:63:
String bucket = uri != null ? uri.getHost(): "";: 'ctor def' child has
incorrect indentation level 6, expected level should be 4. [Indentation]
./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/TemporaryAWSCredentialsProvider.java:64:
Configuration c = ProviderUtils.excludeIncompatibleCredentialProviders(:
'ctor def' child has incorrect indentation level 6, expected level should be 4.
[Indentation]
./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/TemporaryAWSCredentialsProvider.java:66:
this.accessKey = lookupPassword(bucket, c, ACCESS_KEY);: 'ctor def' child
has incorrect indentation level 6, expected level should be 4. [Indentation]
./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/TemporaryAWSCredentialsProvider.java:67:
this.secretKey = lookupPassword(bucket, c, SECRET_KEY);: 'ctor def' child
has incorrect indentation level 6, expected level should be 4. [Indentation]
./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/TemporaryAWSCredentialsProvider.java:68:
this.sessionToken = lookupPassword(bucket, c, SESSION_TOKEN);: 'ctor def'
child has incorrect indentation level 6, expected level should be 4.
[Indentation]
./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3native/S3xLoginHelper.java:26:import
org.slf4j.Logger;:8: Unused import - org.slf4j.Logger. [UnusedImports]
./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3native/S3xLoginHelper.java:27:import
org.slf4j.LoggerFactory;:8: Unused import - org.slf4j.LoggerFactory.
[UnusedImports]
./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3native/S3xLoginHelper.java:42:
* The core function of this class was the extraction and decoding of
user:secret: Line is longer than 80 characters (found 81). [LineLength]
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/TestS3AAWSCredentialsProvider.java:361:
public IOERaisingProvider(URI uri, Configuration conf):5: Redundant
'public' modifier. [RedundantModifier]
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3native/TestS3xLoginHelper.java:90:
S3xLoginHelper.LOGIN_WARNING,: 'method call' child has incorrect
indentation level 4, expected level should be 6. [Indentation]
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3native/TestS3xLoginHelper.java:91:
() -> S3xLoginHelper.buildFSURI(uri));: '(' has incorrect indentation level
4, expected level should be 8. [Indentation]
{code}
> Remove s3a user:secret authentication
> -------------------------------------
>
> Key: HADOOP-14833
> URL: https://issues.apache.org/jira/browse/HADOOP-14833
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Affects Versions: 3.0.0-beta1
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Major
> Attachments: HADOOP-14833-001.patch
>
>
> Remove the s3a://user:secret@host auth mechanism from S3a.
> As well as being insecure, it causes problems with S3Guard's URI matching
> code.
> Proposed: cull it utterly. We've been telling people to stop using it since
> HADOOP-3733
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
