[ 
https://issues.apache.org/jira/browse/HADOOP-15717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Szilard Nemeth updated HADOOP-15717:
------------------------------------
    Description: 
The reason for logging the IOexception is that it helps troubleshooting what 
caused the exception, as it can come from two different calls from the 
try-catch.
I came across a case where tgt.getEndTime() was returned null and it resulted 
in an NPE.
I can see that [~gabor.bota] handled this with HADOOP-15593, but apart from 
logging the fact that the ticket's {{endDate}} was null, we have not logged the 
exception at all.
With the current code, the exception is swallowed and the thread terminates in 
case the ticket's {{endDate}} is null. 
As this can happen with OpenJDK for example, it is required to print the 
exception (stack trace, message) to the log.

The code should be updated here: 
https://github.com/apache/hadoop/blob/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/UserGroupInformation.java#L918


  was:
The reason for logging the IOexception is that it helps troubleshooting what 
caused the exception, as it can come from two different calls from the 
try-catch.
I came across a case where tgt.getEndTime() was returned null and it resulted 
in an NPE.
I can see that [~gabor.bota] handled this with HADOOP-15593, but apart from 
logging the fact that the ticket's {{endDate}} was null, we have not logged the 
exception at all.

The code should be updated here: 
https://github.com/apache/hadoop/blob/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/UserGroupInformation.java#L918



> TGT renewal thread does not log IOException
> -------------------------------------------
>
>                 Key: HADOOP-15717
>                 URL: https://issues.apache.org/jira/browse/HADOOP-15717
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Szilard Nemeth
>            Assignee: Szilard Nemeth
>            Priority: Major
>         Attachments: HADOOP-15717.001.patch
>
>
> The reason for logging the IOexception is that it helps troubleshooting what 
> caused the exception, as it can come from two different calls from the 
> try-catch.
> I came across a case where tgt.getEndTime() was returned null and it resulted 
> in an NPE.
> I can see that [~gabor.bota] handled this with HADOOP-15593, but apart from 
> logging the fact that the ticket's {{endDate}} was null, we have not logged 
> the exception at all.
> With the current code, the exception is swallowed and the thread terminates 
> in case the ticket's {{endDate}} is null. 
> As this can happen with OpenJDK for example, it is required to print the 
> exception (stack trace, message) to the log.
> The code should be updated here: 
> https://github.com/apache/hadoop/blob/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/UserGroupInformation.java#L918



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to