[
https://issues.apache.org/jira/browse/HADOOP-15755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16614840#comment-16614840
]
Jason Lowe commented on HADOOP-15755:
-------------------------------------
Thanks for the report and patch! Fix looks fine. It could use
Collections.emptyList but that's not a must-fix.
Would you mind adding a unit test? It's trivial in this case since the test
just needs to invoke the method with a null args parameter. That way if
someone later refactors the method a test will verify this doesn't regress.
> StringUtils#createStartupShutdownMessage throws NPE when args is null
> ---------------------------------------------------------------------
>
> Key: HADOOP-15755
> URL: https://issues.apache.org/jira/browse/HADOOP-15755
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Lokesh Jain
> Assignee: Lokesh Jain
> Priority: Major
> Attachments: HADOOP-15755.001.patch
>
>
> StringUtils#createStartupShutdownMessage uses
> {code:java}
> Arrays.asList(args)
> {code}
> which throws NPE when args is null.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
