[
https://issues.apache.org/jira/browse/HADOOP-15757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16615380#comment-16615380
]
Thomas Marquardt commented on HADOOP-15757:
-------------------------------------------
LGTM, couple minor comments:
*Base64.java*:
L33: {{byte DECODE_64[]}} should be {{byte[] DECODE_64}}.
*TestConfigurationValidators.java*:
L24: imports should be in alphabetical order, so
org.apache.hadoop.fs.azurebfs.utils.Base64 is below
org.apache.hadoop.fs.azurebfs.contracts.exceptions.InvalidConfigurationValueException
Otherwise, +1 from me. After we move to trunk, let's move this to
hadoop-common. We've actually used this class for years, so we no it is
correct and very stable.
> ABFS: remove dependency on common-codec Base64
> ----------------------------------------------
>
> Key: HADOOP-15757
> URL: https://issues.apache.org/jira/browse/HADOOP-15757
> Project: Hadoop Common
> Issue Type: Sub-task
> Reporter: Da Zhou
> Assignee: Da Zhou
> Priority: Major
> Attachments: HADOOP-15757-HADOOP-15407-001.patch
>
>
> Currently ABFS relies on common-codec Base64, because different versions of
> common-codec are widely used and some are missing the methods needed by ABFS,
> it cause lots of "no such method" exception in customer's env, hence we
> decide to add util for Base64 to avoid such issues in future.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
