[
https://issues.apache.org/jira/browse/HADOOP-15717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16616891#comment-16616891
]
Szilard Nemeth commented on HADOOP-15717:
-----------------------------------------
Hi [~xiaochen]!
Thanks for your comment!
I'm not sure what 2 existing {{LOG.error}} statements you referred to.
If you referred to the block {{catch \(IOException ie\) {}} in the {{run}}
method, I would say those are not the best candidates to add the exception as a
logging parameter, as the first {{LOG.error}} statement deals with the case
when the {{tgt}} is destroyed, the second {{LOG.error}} statement handles
possible NPEs coming from {{tgt.getEndTime\(\).getTime\(\)}}.
It can happen you meant a different thing, please clarify!
I'm still voting for the keeping my patch as a solution, so logging the
exception on the first line of the catch-block in a generic fashion.
> TGT renewal thread does not log IOException
> -------------------------------------------
>
> Key: HADOOP-15717
> URL: https://issues.apache.org/jira/browse/HADOOP-15717
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Szilard Nemeth
> Assignee: Szilard Nemeth
> Priority: Major
> Attachments: HADOOP-15717.001.patch
>
>
> I came across a case where tgt.getEndTime() was returned null and it resulted
> in an NPE, this observation was popped out of a test suite execution on a
> cluster. The reason for logging the {{IOException}} is that it helps to
> troubleshoot what caused the exception, as it can come from two different
> calls from the try-catch.
> I can see that [~gabor.bota] handled this with HADOOP-15593, but apart from
> logging the fact that the ticket's {{endDate}} was null, we have not logged
> the exception at all.
> With the current code, the exception is swallowed and the thread terminates
> in case the ticket's {{endDate}} is null.
> As this can happen with OpenJDK for example, it is required to print the
> exception (stack trace, message) to the log.
> The code should be updated here:
> https://github.com/apache/hadoop/blob/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/UserGroupInformation.java#L918
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
