[ 
https://issues.apache.org/jira/browse/HADOOP-15723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16619074#comment-16619074
 ] 

Steve Loughran commented on HADOOP-15723:
-----------------------------------------

# log message needs to be at debug, otherwise every FS operation without this 
binding will print a warning message.
# ideally, there'd be some mockito implementation of this set to trigger auth 
failures, to see what happens
# w.r.t  AdlAuthorizationException, I generally prefer 
{{org.apache.hadoop.fs.PathIOException}} subclasses for things which always 
raise exceptions related to operations and paths...it's got a more standard 
structure, and tests can retrieve those values and make assertions. But that's 
a personal preference, nothing else
# what is meant to happen on {{AdlAuthorizer.isAuthorized}} if the varargs path 
list is of size 0? If its a requirement to be size >1, should be mentioned in 
the javadocs that an IllegalArgumentException will be raised.
# the AdlAuthorizer methods should be allowed to raise any IOException. Because 
if some IO error happens in init/isAuthorized, there's no need to catch & wrap 
it in an AdlAuthorizationException —it should be thrown up. And network errors 
will happen, won't they?

> ABFS: Ranger Support
> --------------------
>
>                 Key: HADOOP-15723
>                 URL: https://issues.apache.org/jira/browse/HADOOP-15723
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/azure
>            Reporter: Thomas Marquardt
>            Assignee: Da Zhou
>            Priority: Major
>         Attachments: HADOOP-15273-HADOOP-15407-001.patch, 
> HADOOP-15273-HADOOP-15407-002.patch
>
>
> Add support for Ranger



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to