[
https://issues.apache.org/jira/browse/HADOOP-15773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16620850#comment-16620850
]
Aaron Fabbri commented on HADOOP-15773:
---------------------------------------
Patch looks good, +1.
I did not apply the patch on top of the HADOOP-15407 patch, nor test it, but I
did review the changes and they all look good. No logic changes, just
checkstyle stuff.
> ABFS: Fix issues raised by Yetus
> --------------------------------
>
> Key: HADOOP-15773
> URL: https://issues.apache.org/jira/browse/HADOOP-15773
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/azure
> Reporter: Sean Mackrory
> Assignee: Sean Mackrory
> Priority: Major
> Attachments: HADOOP-15773-HADOOP-15407.001.patch
>
>
> I aggregated the HADOOP-15407 branch into a single patch and posted it on
> HADOOP-15770 just to get an aggregate report of all current issues raised by
> Yetus. There was a javac deprecation warning, a number of checkstyle issues,
> some whitespace issues, and there are a couple of valid javadoc errors I see
> locally. Let's fix them before we merge.
> I see a number of wildcard imports, all for the contents of large classes of
> configuration constants, and I think those should stay the way they are.
> There are a number of existing checkstyle issues in WASB, too that are
> irrelevant for the merge, and there are some field visibility issues in tests
> that are required that way for the tests to work as designed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
