[
https://issues.apache.org/jira/browse/HADOOP-14556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16621172#comment-16621172
]
Hadoop QA commented on HADOOP-14556:
------------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
24s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 16 new or modified test
files. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 5m
38s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 18m
2s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 15m
32s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 3m
7s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 2m
18s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
16m 41s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source:
hadoop-project {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
21s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m
3s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
21s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
28s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 13m
54s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 13m 54s{color}
| {color:red} root generated 3 new + 1335 unchanged - 0 fixed = 1338 total (was
1335) {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
2m 54s{color} | {color:orange} root: The patch generated 58 new + 103 unchanged
- 6 fixed = 161 total (was 109) {color} |
| {color:red}-1{color} | {color:red} mvnsite {color} | {color:red} 0m
43s{color} | {color:red} hadoop-aws in the patch failed. {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch has 26 line(s) that end in whitespace. Use
git apply --whitespace=fix <<patch_file>>. Refer
https://git-scm.com/docs/git-apply {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
3s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
11m 0s{color} | {color:green} patch has no errors when building and testing
our client artifacts. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source:
hadoop-project {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
58s{color} | {color:red} hadoop-tools/hadoop-aws generated 8 new + 0 unchanged
- 0 fixed = 8 total (was 0) {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m
32s{color} | {color:red} hadoop-tools_hadoop-aws generated 2 new + 1 unchanged
- 0 fixed = 3 total (was 1) {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
25s{color} | {color:green} hadoop-project in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 8m
29s{color} | {color:green} hadoop-common in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 4m 43s{color}
| {color:red} hadoop-aws in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
43s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}114m 50s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hadoop-tools/hadoop-aws |
| | Unwritten field:AbstractSessionCredentialsProvider.java:[line 53] |
| | org.apache.hadoop.fs.s3a.auth.RolePolicies.S3_ROOT_READ_OPERATIONS should
be package protected At RolePolicies.java: At RolePolicies.java:[line 198] |
| | org.apache.hadoop.fs.s3a.auth.RolePolicies.S3_ROOT_RW_OPERATIONS should
be package protected At RolePolicies.java: At RolePolicies.java:[line 236] |
| | Found reliance on default encoding in
org.apache.hadoop.fs.s3a.auth.delegation.AbstractDelegationTokenBinding.<static
initializer for AbstractDelegationTokenBinding>():in
org.apache.hadoop.fs.s3a.auth.delegation.AbstractDelegationTokenBinding.<static
initializer for AbstractDelegationTokenBinding>(): String.getBytes() At
AbstractDelegationTokenBinding.java:[line 186] |
| |
org.apache.hadoop.fs.s3a.auth.delegation.AbstractDelegationTokenBinding.PASSWORD
should be package protected At AbstractDelegationTokenBinding.java: At
AbstractDelegationTokenBinding.java:[line 186] |
| | There is an apparent infinite recursive loop in
org.apache.hadoop.fs.s3a.auth.delegation.AbstractDelegationTokenBinding$TokenSecretManager.createIdentifier()
At AbstractDelegationTokenBinding.java:recursive loop in
org.apache.hadoop.fs.s3a.auth.delegation.AbstractDelegationTokenBinding$TokenSecretManager.createIdentifier()
At AbstractDelegationTokenBinding.java:[line 208] |
| | Should
org.apache.hadoop.fs.s3a.auth.delegation.AbstractDelegationTokenBinding$TokenSecretManager
be a _static_ inner class? At AbstractDelegationTokenBinding.java:inner
class? At AbstractDelegationTokenBinding.java:[lines 192-208] |
| | Found reliance on default encoding in
org.apache.hadoop.fs.s3a.auth.delegation.S3ADelegationTokens.<static
initializer for S3ADelegationTokens>():in
org.apache.hadoop.fs.s3a.auth.delegation.S3ADelegationTokens.<static
initializer for S3ADelegationTokens>(): String.getBytes() At
S3ADelegationTokens.java:[line 396] |
| Failed junit tests | hadoop.fs.s3a.TestS3AAWSCredentialsProvider |
| | hadoop.fs.s3a.commit.staging.TestStagingPartitionedTaskCommit |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:4b8c2b1 |
| JIRA Issue | HADOOP-14556 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12940466/HADOOP-14556-007.patch
|
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient findbugs checkstyle xml |
| uname | Linux f7f991227c25 4.4.0-133-generic #159-Ubuntu SMP Fri Aug 10
07:31:43 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / 042bf74 |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.0-RC1 |
| javac |
https://builds.apache.org/job/PreCommit-HADOOP-Build/15229/artifact/out/diff-compile-javac-root.txt
|
| checkstyle |
https://builds.apache.org/job/PreCommit-HADOOP-Build/15229/artifact/out/diff-checkstyle-root.txt
|
| mvnsite |
https://builds.apache.org/job/PreCommit-HADOOP-Build/15229/artifact/out/patch-mvnsite-hadoop-tools_hadoop-aws.txt
|
| whitespace |
https://builds.apache.org/job/PreCommit-HADOOP-Build/15229/artifact/out/whitespace-eol.txt
|
| findbugs |
https://builds.apache.org/job/PreCommit-HADOOP-Build/15229/artifact/out/new-findbugs-hadoop-tools_hadoop-aws.html
|
| javadoc |
https://builds.apache.org/job/PreCommit-HADOOP-Build/15229/artifact/out/diff-javadoc-javadoc-hadoop-tools_hadoop-aws.txt
|
| unit |
https://builds.apache.org/job/PreCommit-HADOOP-Build/15229/artifact/out/patch-unit-hadoop-tools_hadoop-aws.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HADOOP-Build/15229/testReport/ |
| Max. process+thread count | 1431 (vs. ulimit of 10000) |
| modules | C: hadoop-project hadoop-common-project/hadoop-common
hadoop-tools/hadoop-aws U: . |
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/15229/console |
| Powered by | Apache Yetus 0.8.0 http://yetus.apache.org |
This message was automatically generated.
> S3A to support Delegation Tokens
> --------------------------------
>
> Key: HADOOP-14556
> URL: https://issues.apache.org/jira/browse/HADOOP-14556
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Affects Versions: 3.2.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Major
> Attachments: HADOOP-14556-001.patch, HADOOP-14556-002.patch,
> HADOOP-14556-003.patch, HADOOP-14556-004.patch, HADOOP-14556-005.patch,
> HADOOP-14556-007.patch, HADOOP-14556.oath-002.patch, HADOOP-14556.oath.patch
>
>
> S3A to support delegation tokens where
> * an authenticated client can request a token via
> {{FileSystem.getDelegationToken()}}
> * Amazon's token service is used to request short-lived session secret & id;
> these will be saved in the token and marshalled with jobs
> * A new authentication provider will look for a token for the current user
> and authenticate the user if found
> This will not support renewals; the lifespan of a token will be limited to
> the initial duration. Also, as you can't request an STS token from a
> temporary session, IAM instances won't be able to issue tokens.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
