[ 
https://issues.apache.org/jira/browse/HADOOP-15795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16636099#comment-16636099
 ] 

Thomas Marquardt commented on HADOOP-15795:
-------------------------------------------

AzureBlobFileSystem.java

  L157: isSecure always returns false, so lets remove it to make this code 
easier to read.

AzureBlobFileSystemStore.java

  L140: Could we clean this up a bit and get rid of isSecure?  Please note that 
when "fs.azure.always.use.https" is *true*, we +always+ use HTTPS.  On the 
other hand, if "fs.azure.always.use.https" is *false,* we use *HTTP* if the FS 
URI scheme is "abfs" and we will use *HTTPS* if the FS URI scheme is "abfss".   
The code is currently no doing this.

ITestClientUrlScheme.java

  This test doesn't correctly cover the case where "fs.azure.always.use.https" 
is *false* and the FS URI scheme is "abfss".  If you setup your real test 
config file this way, the driver will use HTTP.  It should use HTTPS.

> Making HTTPS as default for ABFS
> --------------------------------
>
>                 Key: HADOOP-15795
>                 URL: https://issues.apache.org/jira/browse/HADOOP-15795
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/azure
>    Affects Versions: 3.2.0
>            Reporter: Da Zhou
>            Assignee: Da Zhou
>            Priority: Major
>         Attachments: HADOOP-15795-001.patch, HADOOP-15795-002.patch, 
> HADOOP-15795-003.patch
>
>
>  HTTPS should be used as default in ABFS, but also  we provide a 
> configuration key for user to disable it in non-secure mode.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to