Github user aajisaka commented on a diff in the pull request:

    https://github.com/apache/hadoop/pull/421#discussion_r222153880
  
    --- Diff: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/pom.xml ---
    @@ -202,6 +202,13 @@
                 <groupId>ro.isdc.wro4j</groupId>
                 <artifactId>wro4j-maven-plugin</artifactId>
                 <version>1.7.9</version>
    +              <dependencies>
    +                <dependency>
    +                  <groupId>org.mockito</groupId>
    +                  <artifactId>mockito-core</artifactId>
    +                  <version>2.18.0</version>
    +                </dependency>
    +              </dependencies>
    --- End diff --
    
    Thanks @vbmudalige for the pull request.
    * Would you comment that "TODO: remove this dependency after upgrading 
wro4j-maven-plugin to 1.8.1 or later"?
    * Would you remove 2 whitespaces from the indents? 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to