[
https://issues.apache.org/jira/browse/HADOOP-15809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16638110#comment-16638110
]
Steve Loughran commented on HADOOP-15809:
-----------------------------------------
LGTM. Checkstyle is asking for a javadoc comment on the now-public class. Can
you add that? After which it'll be ready to go in
{code}
./hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/oauth2/AzureADAuthenticator.java:164:
public static class HttpException extends IOException {: Missing a Javadoc
comment. [JavadocType]
{code}
> ABFS: better exception handling when making getAccessToken call
> ---------------------------------------------------------------
>
> Key: HADOOP-15809
> URL: https://issues.apache.org/jira/browse/HADOOP-15809
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/azure
> Affects Versions: 3.2.0
> Reporter: Da Zhou
> Assignee: Da Zhou
> Priority: Major
> Attachments: HADOOP-15809-001.patch
>
>
> Currently in *getTokenSingleCall()*: if it get a HTTP failure response, it
> tries to consume inputStream in httpUrlConnection, which will *always* lead
> to an *IOException* and this exception never get checked in
> *AzureADAuthenticator*.
> As a result the httpStatus code is never checked in the retry policy of
> AzureADAuthenticator. Tthat IOException will be caught by AbfsRestOperation,
> which will keep on retrying.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
