[
https://issues.apache.org/jira/browse/HADOOP-11100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16643100#comment-16643100
]
Adam Antal commented on HADOOP-11100:
-------------------------------------
Uploaded patch v2. Added "fs.ftp.timeout.enabled" to config whether the timeout
should be set.
The change only affected
{code:java}
private FTPClient connect() throws IOException {code}
method, which is private, so it's not intended to be tested directly. Other way
I can think the timeout could be tested is some mocking approach, but it needs
refactoring, and we did not test that function before either. In short, IMO
testing if not applicable.
As a first guess 5 min seems ok for default value - can be modified later.
> Support to configure ftpClient.setControlKeepAliveTimeout
> -----------------------------------------------------------
>
> Key: HADOOP-11100
> URL: https://issues.apache.org/jira/browse/HADOOP-11100
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs
> Affects Versions: 2.3.0
> Reporter: Krishnamoorthy Dharmalingam
> Assignee: Adam Antal
> Priority: Minor
> Attachments: HADOOP-11100.002.patch, HDFS-11000.001.patch
>
>
> In FTPFilesystem or Configuration, timeout is not possible to configure.
> It is very straight forward to configure, in FTPFilesystem.connect() method.
> ftpClient.setControlKeepAliveTimeout
> Like
> private FTPClient connect() throws IOException {
> ...
> String timeout = conf.get("fs.ftp.timeout." + host);
> ...
> ftpClient.setControlKeepAliveTimeout(new Integer(300));
> ....
> }
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
