[
https://issues.apache.org/jira/browse/HADOOP-15828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16650455#comment-16650455
]
Íñigo Goiri commented on HADOOP-15828:
--------------------------------------
The refactor of the constructor is a little tough to grasp, help me out here.
So basically instead of using null lists we use empty ones; that's good as we
simplify other parts of the code.
My question comes for the old else case where we used to set the all to false
and the rest to null; how is that covered now?
BTW, what are we now covering by adding host2 that we weren't before?
> Review of MachineList class
> ---------------------------
>
> Key: HADOOP-15828
> URL: https://issues.apache.org/jira/browse/HADOOP-15828
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Affects Versions: 3.2.0
> Reporter: BELUGA BEHR
> Assignee: BELUGA BEHR
> Priority: Minor
> Attachments: HADOOP-15828.1.patch, HADOOP-15828.2.patch,
> HADOOP-15828.3.patch
>
>
> Clean up and simplify class {{MachineList}}. Primarily, remove LinkedList
> implementation and use empty collections instead of 'null' values, add
> logging.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
