[
https://issues.apache.org/jira/browse/HADOOP-15836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16657350#comment-16657350
]
BELUGA BEHR commented on HADOOP-15836:
--------------------------------------
I though about this previously. This information can be read from a config
file and loaded into a {{HashSet}} (as is currently implemented). If the
software needed to spit out the user/group names back to the screen, or back to
a file, the ordering of the output would almost certainly not be the same as
the input (just depends on how the stuff is ordered in the {{HashMap}}). So as
things stand, the software will most likely not build the output in the same
order as the input. Therefore, it appears that there is no constraints on how
the stuff is ordered. If we care about the output matching the input exactly,
that should be a new ticket. Since the order doesn't matter, I think it might
be more pleasant to a human operator if the list is ordered alphabetically.
> Review of AccessControlList.java
> --------------------------------
>
> Key: HADOOP-15836
> URL: https://issues.apache.org/jira/browse/HADOOP-15836
> Project: Hadoop Common
> Issue Type: Improvement
> Components: common, security
> Affects Versions: 3.2.0
> Reporter: BELUGA BEHR
> Assignee: BELUGA BEHR
> Priority: Minor
> Attachments: HADOOP-15836.1.patch
>
>
> * Improve unit tests (expected / actual were backwards)
> * Unit test expected elements to be in order but the class's return
> Collections were unordered
> * Formatting cleanup
> * Removed superfluous white space
> * Remove use of LinkedList
> * Removed superfluous code
> * Use {{unmodifiable}} Collections where JavaDoc states that caller must not
> manipulate the data structure
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
