[
https://issues.apache.org/jira/browse/HADOOP-15957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16703085#comment-16703085
]
Steve Loughran commented on HADOOP-15957:
-----------------------------------------
Production code seems OK to my reading.
Test-wise, there's too much cut-and-paste of the asserts, without anything to
debug failures. I always prefer test cases where a failure in a jenkins run
provides enough to track down the problem, and lines like
{code}
assertEquals(false, store.isPageBlobKey("data/dir/recovered.txt"));
assertEquals(true, store.isPageBlobKey("data/mypageblobfiles/recovered.txt"));
{code}
dont' do that much
how about some method
{code}
expectPageBlobKey(outcome, store, path) {
assertEquals("unexpected isPageBlobKey(" + path + ") result",
expected, store.isPageBlobKey(path))
}
// with uses like
expectPageBlobKey(false, store, "data/dir/recovered.txt"));
expectPageBlobKey(true, store, "data/mypageblobfiles/recovered.txt"));
// ..etc
{code}
> WASB: Add asterisk wildcard support for PageBlobDirSet
> ------------------------------------------------------
>
> Key: HADOOP-15957
> URL: https://issues.apache.org/jira/browse/HADOOP-15957
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs/azure
> Affects Versions: 3.2.0
> Reporter: Da Zhou
> Assignee: Da Zhou
> Priority: Major
> Attachments: HADOOP-15957-001.patch
>
>
> In WASB, property "*fs.azure.page.blob.dir*" only support literal directory
> name.
> We need to add support for wildcard '*' to represent for any directory name.
> For example, the following pattern should be supported:
> {code:java}
> /dir1/dir2
> /dir1/*/dir3
> /dir1/*/*/dir4
> /dir1/*/*/file
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
