[
https://issues.apache.org/jira/browse/HADOOP-15954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16709038#comment-16709038
]
Steve Loughran commented on HADOOP-15954:
-----------------------------------------
Things don't compile; I'll leave you to work out what went wrong there.
Qucik review of some parts of the code:
* Some minimal docs will be needed for this. Even if currently there is one
single user, there may be more in future, and all of us will end up trying to
debug a stack trace related to it at some point
* It's critical that the "owner" of the FS is used over the
UGI.getCurrentUser(); the owner is cached in {{AzureBlobFileSystem.initialize}}
and can be retrieved later.
Recommend: pass it in as a constructor to the transformer. That'll make testing
in a miniKDC cluster viable.
h3. getIdentityTransformer
switch to using Preconditions.checkArgument/checkNotNull for validation
In the final catch Exception & wrap, include toString value of caught ex in the
new exception message.
> ABFS: Enable owner and group conversion for MSI and login user using OAuth
> --------------------------------------------------------------------------
>
> Key: HADOOP-15954
> URL: https://issues.apache.org/jira/browse/HADOOP-15954
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/azure
> Affects Versions: 3.2.0
> Reporter: junhua gu
> Assignee: junhua gu
> Priority: Major
> Attachments: HADOOP-15954-001.patch, HADOOP-15954-002.patch,
> HADOOP-15954-003.patch, HADOOP-15954-004.patch
>
>
> Add support for overwriting owner and group in set/get operations to be the
> service principal id when OAuth is used. Add support for upn short name
> format.
>
> Add Standard Transformer for SharedKey / Service
> Add interface provides an extensible model for customizing the acquisition of
> Identity Transformer.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
