[
https://issues.apache.org/jira/browse/HADOOP-7384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Todd Lipcon updated HADOOP-7384:
--------------------------------
Attachment: hadoop-7384.txt
Here's a transcript of my manual testing:
todd@todd-w510:~/git/hadoop-common/common$ git show | PATCH=echo
src/test/bin/smart-apply-patch.sh -
Looks like this is a git patch. Stripping a/ and b/ prefixes
and incrementing PLEVEL
Looks like this is relative to project root. Increasing PLEVEL
Going to apply patch with: echo -p2
-p2 -E
todd@todd-w510:~/git/hadoop-common/common$ git show --no-prefix | PATCH=echo
src/test/bin/smart-apply-patch.sh -
Looks like this is relative to project root. Increasing PLEVEL
Going to apply patch with: echo -p1
-p1 -E
todd@todd-w510:~/git/hadoop-common/common$ git show --relative | PATCH=echo
src/test/bin/smart-apply-patch.sh -
Looks like this is a git patch. Stripping a/ and b/ prefixes
and incrementing PLEVEL
Going to apply patch with: echo -p1
-p1 -E
todd@todd-w510:~/git/hadoop-common/common$ git show --relative --no-prefix |
PATCH=echo src/test/bin/smart-apply-patch.sh -
Going to apply patch with: echo -p0
-p0 -E
todd@todd-w510:~/git/hadoop-common/common$ echo > CHANGES.txt ; echo >
../mapreduce/CHANGES.txt
todd@todd-w510:~/git/hadoop-common/common$ git diff | PATCH=echo
src/test/bin/smart-apply-patch.sh -
Looks like this is a git patch. Stripping a/ and b/ prefixes
and incrementing PLEVEL
Looks like this is a cross-subproject patch. Not supported!
todd@todd-w510:~/git/hadoop-common/common$ echo $?
1
> Allow test-patch to be more flexible about patch format
> -------------------------------------------------------
>
> Key: HADOOP-7384
> URL: https://issues.apache.org/jira/browse/HADOOP-7384
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 0.23.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Attachments: hadoop-7384.txt
>
>
> Right now the test-patch process only accepts patches that are generated as
> "-p0" relative to common/, hdfs/, or mapreduce/. This has always been
> annoying for git users where the default patch format is -p1. It's also now
> annoying for SVN users who may generate a patch relative to trunk/ instead of
> the subproject subdirectory. We should auto-detect the correct patch level.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
