[
https://issues.apache.org/jira/browse/HADOOP-15808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16715232#comment-16715232
]
Larry McCay commented on HADOOP-15808:
--------------------------------------
[[email protected]] - what is the difference between no class found and not
being able to be instantiated - they are separate exceptions but wondering
whether the javadoc is correct in...
+ * @return the token identifier, or null if there was no class found for it
+ * @throws IOException failure to unmarshall the data
+ * @throws RuntimeException if the token class could not be instantiated.
is it literally distinguishing between the two - so that a class that is found
but cannot be loaded gets a runtime exception and a class not found gets a null
returned?
I assume once this gets in a patch for all of the consumers that will need to
accommodate null will created?
> Harden Token service loader use
> -------------------------------
>
> Key: HADOOP-15808
> URL: https://issues.apache.org/jira/browse/HADOOP-15808
> Project: Hadoop Common
> Issue Type: Improvement
> Components: security
> Affects Versions: 2.9.1, 3.1.2
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Major
> Attachments: HADOOP-15808-001.patch, HADOOP-15808-002.patch,
> HADOOP-15808-003.patch
>
>
> The Hadoop token service loading (identifiers, renewers...) works provided
> there's no problems loading any registered implementation. If there's a
> classloading or classcasting problem, the exception raised will stop all
> token support working; possibly the application not starting.
> This matters for S3A/HADOOP-14556 as things may not load if aws-sdk isn't on
> the classpath. It probably lurks in the wasb/abfs support too, but things
> have worked there because the installations with DT support there have always
> had correctly set up classpaths.
> Fix: do what we did for the FS service loader. Catch failures to instantiate
> a service provider impl and skip it
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
