[ 
https://issues.apache.org/jira/browse/HADOOP-15978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16721883#comment-16721883
 ] 

Wei-Chiu Chuang commented on HADOOP-15978:
------------------------------------------

Thanks for the patch, Daryn!

* Does it support rolling restart? It’s always a pain to do this kind of change 
at RPC level.

* some refactor work is greatly appreciated. The Server.java is at more than 
4000 lines now.
* add ipc.server.netty.enable in core-default.xml
* shading: patch doesn’t compile due to shading checks. Need to update 
ensure-jars-have-correct-contents.sh to add allowed jar class path.
{code}
allowed_expr+="|^hrpc/"
{code}
* netty: hadoop-project/pom.xml already declares a dependency on io.netty-all, 
and version is 4.0.52.Final, different than the one used in this patch.
* Do we always want to use EpollServerSocketChannel for Linux? The similar 
netty initialization in HBase asyncfs implementation checks if the os.arch is 
amd64.
* Does it require netty-transport-native-epoll as described in 
https://netty.io/wiki/native-transports.html?
* Once TLS is implemented and enabled, what configuration or additional 
preparation will be required? It seems both client and server will require 
generating additional certificates.

> Add Netty support to the RPC server
> -----------------------------------
>
>                 Key: HADOOP-15978
>                 URL: https://issues.apache.org/jira/browse/HADOOP-15978
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: ipc, security
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>            Priority: Major
>         Attachments: HADOOP-15978.patch
>
>
> Adding Netty will allow later using a native TLS transport layer with much 
> better performance than that offered by Java's SSLEngine.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to