[
https://issues.apache.org/jira/browse/HADOOP-16014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16725098#comment-16725098
]
Kitti Nanasi commented on HADOOP-16014:
---------------------------------------
Thanks [~dineshchitlangia] for the patch! Overall the patch looks good to me.
I only have a minor comment that you can define a global timeout for the whole
test class like this:
{code:java}
@Rule
public Timeout globalTimeout = new Timeout(60000);
{code}
> Fix test, checkstyle and javadoc issues in TestKerberosAuthenticationHandler
> ----------------------------------------------------------------------------
>
> Key: HADOOP-16014
> URL: https://issues.apache.org/jira/browse/HADOOP-16014
> Project: Hadoop Common
> Issue Type: Improvement
> Components: test
> Reporter: Dinesh Chitlangia
> Assignee: Dinesh Chitlangia
> Priority: Major
> Attachments: HADOOP-16014.001.patch
>
>
> TestKerberosAuthenticationHandler has multiple checkstyle violations, missing
> javadoc and some tests are not annotated with @Test thus not being run.
> This jira aims to fix above issues.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
