[ 
https://issues.apache.org/jira/browse/HADOOP-7390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13049294#comment-13049294
 ] 

Hadoop QA commented on HADOOP-7390:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12482556/hadoop-7390.txt
  against trunk revision 1135636.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified 
tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) 
warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 system test framework.  The patch passed system test framework compile.

Test results: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/631//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/631//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/631//console

This message is automatically generated.

> VersionInfo not generated properly in git after unsplit
> -------------------------------------------------------
>
>                 Key: HADOOP-7390
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7390
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: build
>            Reporter: Thomas Graves
>            Assignee: Todd Lipcon
>            Priority: Minor
>         Attachments: hadoop-7390.txt
>
>
> The version information generated during the build of common when running 
> from git has revision and branch Unknown. I believe this started after the 
> unsplit:
> @HadoopVersionAnnotation(version="0.22.0-SNAPSHOT", revision="Unknown", 
> branch="Unknown",
>                          user="tgraves", date="Tue Jun 14 13:39:10 UTC 2011", 
> url="file:///home/tgraves/git/hadoop-common/common",
>                          srcChecksum="0f78ea668971fe51e7ebf4f97f84eed2")
> The ./src/saveVersion.sh script which generates the package-info.java file 
> with the version info looks for the presence of .git directory and that is 
> now a level up instead of in the common directory.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to