[
https://issues.apache.org/jira/browse/HADOOP-15481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16740563#comment-16740563
]
Erik Krogen commented on HADOOP-15481:
--------------------------------------
Looking great [~cgregori]! I have a few more minor nits:
* I don't think you need the {{@Metrics}} annotation anymore – the
{{DefaultMetricsSystem.instance().register()}} should take care of this, IIUC.
* In the definition of {{MetricsProxy}}, we usually use indentation like:
(hanging indent of 4 spaces)
{code:java}
private static final class MetricsProxy implements FairCallQueueMXBean,
MetricsSource {
{code}
There's some discussion of this
[here|https://www.oracle.com/technetwork/java/javase/documentation/codeconventions-136091.html],
though we typically use 4 spaces instead of 8.
* For the {{name}}, now you do "FairCallQueue.namespace", I'm thinking that
"namespace.FairCallQueue" might be better to match more closely with how the
configurations look?
* I'm starting to think that names like "FairCallQueueSize_p0" might be
better, to make it more clear what the number represents. Let me know what you
think.
> Emit FairCallQueue stats as metrics
> -----------------------------------
>
> Key: HADOOP-15481
> URL: https://issues.apache.org/jira/browse/HADOOP-15481
> Project: Hadoop Common
> Issue Type: Improvement
> Components: metrics, rpc-server
> Reporter: Erik Krogen
> Assignee: Christopher Gregorian
> Priority: Major
> Attachments: HADOOP-15481.001.patch, HADOOP-15481.001.patch,
> HADOOP-15481.002.patch
>
>
> Currently FairCallQueue has some statistics which are exported via JMX: the
> size of each queue, and the number of overflowed calls per queue. These are
> useful statistics to track over time to determine, for example, if queues
> need to be resized. We should emit them via the standard metrics system.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
