aajisaka commented on a change in pull request #449: HDFS-14158. Fix the Checkpointer not to ignore the configured "dfs.namenode.checkpoint.period" > 5 minutes URL: https://github.com/apache/hadoop/pull/449#discussion_r249370983
########## File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/Checkpointer.java ########## @@ -160,7 +159,7 @@ public void run() { break; } try { - Thread.sleep(periodMSec); + Thread.sleep(LongMath.gcd(periodMSec, checkpointPeriodMSec)); Review comment: Now periodMsec is min of checkpointCheckPeriod and checkpointPeriod, so the sleep time is smaller than or equal to the configured checkpoint period. Isn't it? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org