elek commented on a change in pull request #462: HDDS-764. Run S3 smoke tests 
with replication STANDARD.
URL: https://github.com/apache/hadoop/pull/462#discussion_r250134623
 
 

 ##########
 File path: hadoop-ozone/dist/src/main/smoketest/test.sh
 ##########
 @@ -24,6 +23,41 @@ mkdir -p "$DIR/$RESULT_DIR"
 #Should be writeable from the docker containers where user is different.
 chmod ogu+w "$DIR/$RESULT_DIR"
 
+## @description wait until 3 datanodes are up (or 30 seconds)
+## @param the docker-compose file
+wait_for_datanodes(){
+
+  #Reset the timer
+  SECONDS=0
+
+  #Don't give it up until 30 seconds
 
 Review comment:
   This is a bash feature, SECONDS is incremented under the hood:
   
   ```
    SECONDS
                 Each  time  this  parameter is referenced, the number of 
seconds since shell invocation is returned.  If a value is assigned to SECONDS, 
the value returned upon subsequent
                 references is the number of seconds since the assignment plus 
the value assigned.  If SECONDS is unset, it loses its special properties, even 
if it is subsequently reset.
   ```
   (from man bash)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to