[
https://issues.apache.org/jira/browse/HADOOP-16072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16751827#comment-16751827
]
Brian Grunkemeyer commented on HADOOP-16072:
--------------------------------------------
About the QA feedback:
1) I didn't add any new tests. My test was building on Windows.
2) Visual Studio solution files contain tabs. We ideally shouldn't tamper with
that to satisfy a code review requirement. I'll try seeking an authoritative
comment from the MSBuild experts, however I'd like to point out the file
already does contain tabs.
> Visual Studio projects are out of date
> --------------------------------------
>
> Key: HADOOP-16072
> URL: https://issues.apache.org/jira/browse/HADOOP-16072
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Affects Versions: 3.2.0
> Environment: Building on Windows 10 with Visual Studio 2017.
> Reporter: Brian Grunkemeyer
> Assignee: Brian Grunkemeyer
> Priority: Minor
> Labels: build, windows
> Fix For: 3.2.0
>
> Attachments: HADOOP-16072.v1.patch
>
> Original Estimate: 6h
> Remaining Estimate: 6h
>
> On Windows when you build, a part of the build process updates some Visual
> Studio solution and project files. We should simply check in the updated
> version, so that everyone who builds doesn't get stuck with extra changes
> they need to manage.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
