[ 
https://issues.apache.org/jira/browse/HADOOP-15998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16752520#comment-16752520
 ] 

Giovanni Matteo Fumarola commented on HADOOP-15998:
---------------------------------------------------

Thanks [~briangru].
[^HADOOP-15998.v4.patch]solves the issue that [~busbey] mentioned early.

The integration tests 
[https://builds.apache.org/job/PreCommit-HADOOP-Build/15842/artifact/out/patch-shadedclient.txt]
 does not show any more errors.

This is the first time I saw spellcheck errors from Yetus.
[www.shellcheck.net|https://www.shellcheck.net/] provides a live to find and 
fix those errors.

NIT: Please keep the old patch in the Jira for history purposes.

> Jar validation bash scripts don't work on Windows due to platform differences 
> (colons in paths, \r\n)
> -----------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-15998
>                 URL: https://issues.apache.org/jira/browse/HADOOP-15998
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 3.2.0, 3.3.0
>         Environment: Windows 10
> Visual Studio 2017
>            Reporter: Brian Grunkemeyer
>            Assignee: Brian Grunkemeyer
>            Priority: Blocker
>              Labels: build, windows
>             Fix For: 3.3.0
>
>         Attachments: HADOOP-15998.v4.patch
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Building Hadoop fails on Windows due to a few shell scripts that make invalid 
> assumptions:
> 1) Colon shouldn't be used to separate multiple paths in command line 
> parameters. Colons occur in Windows paths.
> 2) Shell scripts that rely on running external tools need to deal with 
> carriage return - line feed differences (lines ending in \r\n, not just \n)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to