[ 
https://issues.apache.org/jira/browse/HADOOP-16073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16762339#comment-16762339
 ] 

BELUGA BEHR commented on HADOOP-16073:
--------------------------------------

[~elgoiri]

With all due respect, there is no such thing as "regular {{Charset}}".  There 
is a {{Charset}} class offered by Google's Guava library that existed to fill 
this shortcoming of the JDK.  However, now that the JDK includes this 
{{StandardCharsets}} class, we should be using it consistently across the 
project.  One could see a situation where the 3rd party library deprecates and 
removes this because the JDK has usurped it.  Moving everything over would 
isolate Hadoop from this and also encourage folks to use the JDK version moving 
forward if that's all they see in the code base.  There's also a minuscule 
memory footprint savings only having to use one instance of the UTF-8 
{{Charset}}.

> Use JDK1.7 StandardCharsets
> ---------------------------
>
>                 Key: HADOOP-16073
>                 URL: https://issues.apache.org/jira/browse/HADOOP-16073
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 3.2.0
>            Reporter: BELUGA BEHR
>            Assignee: BELUGA BEHR
>            Priority: Major
>         Attachments: HADOOP-16073.1.patch
>
>
> Use Java 1.7 
> [StandardCharsets|https://docs.oracle.com/javase/7/docs/api/java/nio/charset/StandardCharsets.html].
>   Every JDK must now include support for several common charsets.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to