[
https://issues.apache.org/jira/browse/HADOOP-16097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16764431#comment-16764431
]
Yiqun Lin commented on HADOOP-16097:
------------------------------------
Nice work, [~xkrogen]! The patch looks great, some minor comments:
*FairCallQueue*
Line 64: Seems not accurate, can we update from '{{users whose calls make up
more than 25% of'}} to '{{users whose calls make up more than 25% and less than
50% of'}}
Line 65: {{more than 12.5% are in}} --> {{more than 12.5% and less than 25%
are in}} Can we add one sentence behind this:
{noformat}
...are placed in the highest priority. The priority level computation for the
users is started from low priority levels since they will be most common.
{noformat}
Line 72: Typo 'an RpcMultiplexer' --> 'a RpcMultiplexer'
Line 85: Can we reword this sentence? Looks a little confused: a incoming
request would receive a backoff request?
{noformat}
an incoming request at priority levels 2 or lower would receive a backoff
request
{noformat}
Line 86: {{and 1 would proceed as normal}} --> {{and 1 would be proceed as
normal}}
Line 111: Can we use {{WeightedRoundRobinMultiplexer}} to replace
{{FairCallQueue}} used Component column?
Two other comments:
* I suppose we lack of the Description for the IdentityProvider controlled by
{{identity-provider.impl}}. Can we document a little of this?
* The image cannot be applied from the patch.
> Provide proper documentation for FairCallQueue
> ----------------------------------------------
>
> Key: HADOOP-16097
> URL: https://issues.apache.org/jira/browse/HADOOP-16097
> Project: Hadoop Common
> Issue Type: Improvement
> Components: documentation, ipc
> Reporter: Erik Krogen
> Assignee: Erik Krogen
> Priority: Major
> Attachments: HADOOP-16097.000.patch, faircallqueue-overview.png
>
>
> FairCallQueue, added in HADOOP-10282, doesn't seem to be well-documented
> anywhere. Let's add in a new documentation for it and related components.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
