[
https://issues.apache.org/jira/browse/HADOOP-16107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Steve Loughran updated HADOOP-16107:
------------------------------------
Status: Patch Available (was: Open)
patch 001:
* TestFutureIO to see what thread the openFile().build call runs on (as initial
hypothesis was "if these open() in a different thread, they may not get
counted".
* add protected method in filesystem to allow subclasses to get the base
builders for input and output
* overwrite createFile/openFile builder calls in ChecksumFileSystem; test to
verify that CRCs are being written/read (Based on byte count alone)
* identify and override all other create/createNonRecursivce calls which were
going to direct to inner FS, hence not creating CRCs
* add tests in TestLocalFileSystem to verify that all
create/createfile/open/openfile calls create/read checksums
o
+also adds a newline to TestJobCounters to ensure it gets tested too. Final
patch commit must omit this.
Test is tagged as blocker as it is significant; it will need partial
backporting of the extra ChecksumFileSystem
create/createNonrecursive/createFile methods and tests to match
> LocalFileSystem doesn't wrap all create() or new builder calls; may skip CRC
> logic
> ----------------------------------------------------------------------------------
>
> Key: HADOOP-16107
> URL: https://issues.apache.org/jira/browse/HADOOP-16107
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 3.0.3, 3.3.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Blocker
> Attachments: HADOOP-16107-001.patch
>
>
> LocalFS is a subclass of filterFS, but overrides create and open so that
> checksums are created and read.
> MAPREDUCE-7184 has thrown up that the new builder openFile() call is being
> forwarded to the innerFS without CRC checking. Reviewing/fixing that has
> shown that some of the create methods aren't being correctly wrapped, so not
> generating CRCs
> * createFile() builder
> The following create calls
> {code}
> public FSDataOutputStream createNonRecursive(final Path f,
> final FsPermission permission,
> final EnumSet<CreateFlag> flags,
> final int bufferSize,
> final short replication,
> final long blockSize,
> final Progressable progress) throws IOException;
> public FSDataOutputStream create(final Path f,
> final FsPermission permission,
> final EnumSet<CreateFlag> flags,
> final int bufferSize,
> final short replication,
> final long blockSize,
> final Progressable progress,
> final Options.ChecksumOpt checksumOpt) throws IOException {
> return super.create(f, permission, flags, bufferSize, replication,
> blockSize, progress, checksumOpt);
> }
> {code}
> This means that applications using these methods, directly or indirectly to
> create files aren't actually generating checksums.
> Fix: implement these methods & relay to local create calls, not to the inner
> FS.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
