[ 
https://issues.apache.org/jira/browse/HADOOP-16127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16772948#comment-16772948
 ] 

Steve Loughran commented on HADOOP-16127:
-----------------------------------------

Nice to see some new uses of the java 8 l-expressions; good to use them where 
possible.


Client

L475: include the toString value of the caught IOE in the new one, so if the 
full stack trace is lost, the root cause is preserved

L1360: you've removed all sleeps here entirely. Is that OK?

+1 pending the change and the confirmation




> In ipc.Client, put a new connection could happen after stop
> -----------------------------------------------------------
>
>                 Key: HADOOP-16127
>                 URL: https://issues.apache.org/jira/browse/HADOOP-16127
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: ipc
>            Reporter: Tsz Wo Nicholas Sze
>            Assignee: Tsz Wo Nicholas Sze
>            Priority: Major
>         Attachments: c16127_20190219.patch
>
>
> In getConnection(..), running can be initially true but becomes false before 
> putIfAbsent.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to