[
https://issues.apache.org/jira/browse/HADOOP-16132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16774336#comment-16774336
]
Gabor Bota commented on HADOOP-16132:
-------------------------------------
Hi [~justin.uang]! Thanks for creating this issue and working on it.
There are a few things I noticed that could be improved:
* Currently our test jenkins is not triggering for github pull requests. Please
upload a patch file by following this:
https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute
* In your pr you rearranged and used .* imports. It is not advised to do that,
because it makes hard to do backports. It is advised to turn off the feature
that does that in your ide automatically.
* To work and run tests with S3A we have the following guideline:
https://github.com/apache/hadoop/blob/trunk/hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/testing.md
- so for each patch, you have to run the integration tests against an aws s3
endpoint.
> Support multipart download in S3AFileSystem
> -------------------------------------------
>
> Key: HADOOP-16132
> URL: https://issues.apache.org/jira/browse/HADOOP-16132
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Justin Uang
> Priority: Major
>
> I noticed that I get 150MB/s when I use the AWS CLI
> {code:java}
> aws s3 cp s3://<bucket>/<key> - > /dev/null{code}
> vs 50MB/s when I use the S3AFileSystem
> {code:java}
> hadoop fs -cat s3://<bucket>/<key> > /dev/null{code}
> Looking into the AWS CLI code, it looks like the
> [download|https://github.com/boto/s3transfer/blob/ca0b708ea8a6a1213c6e21ca5a856e184f824334/s3transfer/download.py]
> logic is quite clever. It downloads the next couple parts in parallel using
> range requests, and then buffers them in memory in order to reorder them and
> expose a single contiguous stream. I translated the logic to Java and
> modified the S3AFileSystem to do similar things, and am able to achieve
> 150MB/s download speeds as well. It is mostly done but I have some things to
> clean up first. The PR is here:
> https://github.com/palantir/hadoop/pull/47/files
> It would be great to get some other eyes on it to see what we need to do to
> get it merged.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
