[
https://issues.apache.org/jira/browse/HADOOP-16129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16775447#comment-16775447
]
Wei-Chiu Chuang commented on HADOOP-16129:
------------------------------------------
Hi thanks [~ghuangups] for the patch,
{code}
[-warmup boolean]
{code}
It would be more clear to specify as {{-warmup (true|false)}}
{code}
- eek = kp.generateEncryptedKey(encryptionKeyName);
+ if (eek == null) {
+ eek = kp.generateEncryptedKey(encryptionKeyName);
+ }
{code}
I am not sure about this. eek is a variable shared by multiple threads. You
would see race conditions trying to read/write the variable. How about
initializing eek right after initializing the key provider kp?
> Misc. bug fixes for KMS Benchmark
> ---------------------------------
>
> Key: HADOOP-16129
> URL: https://issues.apache.org/jira/browse/HADOOP-16129
> Project: Hadoop Common
> Issue Type: Bug
> Components: kms
> Affects Versions: 3.3.0
> Reporter: Wei-Chiu Chuang
> Assignee: George Huang
> Priority: Major
> Attachments: HADOOP-16129.001.patch
>
>
> # decrypt operation doesn't need to generate an EEK each time. Only one EEK
> is needed.
> # -warmup takes a boolean parameter (true/false). Update command line help to
> make this clear.
> # -logLevel does not take effect
> # needs a doc
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
