[
https://issues.apache.org/jira/browse/HADOOP-16068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16777086#comment-16777086
]
Masatake Iwasaki commented on HADOOP-16068:
-------------------------------------------
LGTM overall. Added tests including ITestAbfsDelegationTokens succeeded in
Japan region. Some nits found on patch walk through.
AbfsDtFetcher.java: javadoc of getServiceName (just copied from HdfsDtFetcher)
should be updated.
src/main/resources/META-INF/services/org.apache.hadoop.security.token.DtFetcher:
having duplicate entries.
TestCustomOauthTokenProvider.java: subclass of AbstractAbfsIntegrationTest
should be prefixed wth ITest*?
abfs.md:
{code:java}
The [az
storage](https://docs.microsoft.com/en-us/cli/azure/storage/account?view=azure-cli-latest)
subcommand
handles all storage commands, [`az storage account
create`](https://docs.microsoft.com/en-us/cli/azure/storage/account?view=azure-cli-latest#az-storage-account-create)
{code}
Intended target of the first link would be
[https://docs.microsoft.com/en-us/cli/azure/storage?view=azure-cli-latest].
{code:java}
You can list locations from az account list-locations
{code}
Following cmdlines does not show usage of list-locations.
{code:java}
or you can configure an identity to be used only for a specific storage account
with
`fs.azure.account.oauth2.client.id.\<account\_name\>.dfs.core.windows.net`.
{code}
You don't need backslash here.
> ABFS Auth and DT plugins to be bound to specific URI of the FS
> --------------------------------------------------------------
>
> Key: HADOOP-16068
> URL: https://issues.apache.org/jira/browse/HADOOP-16068
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/azure
> Affects Versions: 3.2.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Major
> Attachments: HADOOP-16068-001.patch, HADOOP-16068-002.patch,
> HADOOP-16068-003.patch, HADOOP-16068-004.patch, HADOOP-16068-005.patch,
> HADOOP-16068-006.patch, HADOOP-16068-007.patch, HADOOP-16068-008.patch,
> HADOOP-16068-009.patch, HADOOP-16068-010.patch
>
>
> followup from HADOOP-15692: pass in the URI & conf of the owner FS to bind
> the plugins to the specific FS instance. Without that you can't have per FS
> auth
> +add a stub DT plugin for testing, verify that DTs are collected.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
