[
https://issues.apache.org/jira/browse/HADOOP-16140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16783266#comment-16783266
]
Stephen O'Donnell commented on HADOOP-16140:
--------------------------------------------
Hi [~adam.antal] - Thanks for the review. I did originally have the new test in
a block scope, but it threw up a checkstyle warning, so I took them out. I feel
its probably better to stick with the convention already in the code even if it
violates checkstyle and put them back in. I will upload another patch later
today and put them back in.
Its not simple to move that test into a new method, as that large method
contains a series of tests and the method is called in a couple of different
places (TestTrash and TestViewFSTrash), which I guess is why it is like that,
and somewhat unconventional.
> Add emptyTrash option to purge trash immediately
> ------------------------------------------------
>
> Key: HADOOP-16140
> URL: https://issues.apache.org/jira/browse/HADOOP-16140
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs
> Affects Versions: 3.3.0
> Reporter: Stephen O'Donnell
> Assignee: Stephen O'Donnell
> Priority: Major
> Attachments: HADOOP-14200.002.patch, HADOOP-14200.003.patch,
> HADOOP-14200.004.patch, HDFS-14200.001.patch
>
>
> I have always felt the HDFS trash is missing a simple way to empty the
> current users trash immediately. We have "expunge" but in my experience
> supporting clusters, end users find this confusing. When most end users run
> expunge, they really want to empty their trash immediately and get confused
> when expunge does not do this.
> This can result in users performing somewhat dangerous "skipTrash" operations
> on the trash to free up space. The alternative, which most users will not
> figure out on their own is:
> # Run the expunge command once - this will move the current folder to a
> checkpoint and remove any old checkpoints older than the retention interval
> # Wait over 1 minute and then run expunge again, overriding fs.trash.interval
> to 1 minute using the following command hadoop fs -Dfs.trash.interval=1
> -expunge.
> With this Jira I am proposing to add a extra command, "hdfs dfs -emptyTrash"
> that purges everything in the logged in users Trash directories immediately.
> How would the community feel about adding this new option? I will upload a
> patch for comments.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
