[ 
https://issues.apache.org/jira/browse/HADOOP-7385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13054177#comment-13054177
 ] 

Hadoop QA commented on HADOOP-7385:
-----------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12482614/HADOOP-7385-1.patch
  against trunk revision 1137724.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) 
warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 system test framework.  The patch passed system test framework compile.

Test results: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/668//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/668//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/668//console

This message is automatically generated.

> Remove StringUtils.stringifyException(ie) in logger functions
> -------------------------------------------------------------
>
>                 Key: HADOOP-7385
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7385
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 0.23.0
>            Reporter: Bharath Mundlapudi
>            Assignee: Bharath Mundlapudi
>            Priority: Minor
>             Fix For: 0.23.0
>
>         Attachments: HADOOP-7385-1.patch
>
>
> Apache logger api has an overloaded function which can take the message and 
> exception. I am proposing to clean the logging code with this api.
> ie.:
> Change the code from LOG.warn(msg, 
> StringUtils.stringifyException(exception)); to LOG.warn(msg, exception);

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to