bharatviswa504 commented on a change in pull request #549: HDDS-1213. Support
plain text S3 MPU initialization request
URL: https://github.com/apache/hadoop/pull/549#discussion_r262712309
##########
File path: hadoop-ozone/dist/src/main/smoketest/s3/MultipartUpload.robot
##########
@@ -74,17 +70,16 @@ Test Multipart Upload Complete
Should contain ${result} UploadId
#upload parts
- ${system} = Evaluate platform.system() platform
- Run Keyword if '${system}' == 'Darwin' Create Random file for mac
- Run Keyword if '${system}' == 'Linux' Create Random file for
linux
- ${result} = Execute AWSS3APICli upload-part --bucket
${BUCKET} --key multipartKey1 --part-number 1 --body /tmp/part1 --upload-id
${uploadID}
- ${eTag1} = Execute and checkrc echo '${result}' | jq -r
'.ETag' 0
- Should contain ${result} ETag
+ ${system} = Evaluate platform.system() platform
+ Run Keyword Create Random file 5
+ ${result} = Execute AWSS3APICli upload-part --bucket ${BUCKET}
--key multipartKey1 --part-number 1 --body /tmp/part1 --upload-id ${uploadID}
+ ${eTag1} = Execute and checkrc echo '${result}' | jq -r
'.ETag' 0
+ Should contain ${result} ETag
Execute echo "Part2" > /tmp/part2
- ${result} = Execute AWSS3APICli upload-part --bucket
${BUCKET} --key multipartKey1 --part-number 2 --body /tmp/part2 --upload-id
${uploadID}
- ${eTag2} = Execute and checkrc echo '${result}' | jq -r
'.ETag' 0
- Should contain ${result} ETag
+ ${result} = Execute AWSS3APICli upload-part --bucket ${BUCKET}
--key multipartKey1 --part-number 2 --body /tmp/part2 --upload-id ${uploadID}
+ ${eTag2} = Execute and checkrc echo '${result}' | jq -r
'.ETag' 0
+ Should contain ${result} ETag
Review comment:
Are these unintended changes? As I see the change is indentation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]