ajayydv commented on a change in pull request #547: HDDS-594. SCM CA: DN sends
CSR and uses certificate issued by SCM.
URL: https://github.com/apache/hadoop/pull/547#discussion_r262750596
##########
File path:
hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/TestHddsSecureDatanodeInit.java
##########
@@ -252,23 +251,17 @@ public static void callQuietly(Callable closure) {
public void testGetCSR() throws Exception {
keyCodec.writePublicKey(publicKey);
keyCodec.writePrivateKey(privateKey);
- VersionResponse versionResponse = VersionResponse
- .newBuilder()
- .setVersion(0)
- .addValue(OzoneConsts.SCM_ID, "123")
- .addValue(OzoneConsts.CLUSTER_ID, "123")
- .build();
PKCS10CertificationRequest csr =
- service.getCSR(client, conf, versionResponse);
+ service.getCSR(client, conf);
Review comment:
This is unit test for only CSR generation on DN side. Updated Default
Approver on SCM side to add scm id and cluster id if not already present. Added
corresponding tests in TestDefaultCAServer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
