[
https://issues.apache.org/jira/browse/HADOOP-7206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13054736#comment-13054736
]
Eli Collins commented on HADOOP-7206:
-------------------------------------
Looks great! Thanks for coming up with an implementation that incorporates all
the discussion.
Testing?
Modulo Nicholas' good feedback, minor review feedback follows
* Why is property environment="env" needed? Can we remove that same setting
from the findbugs target now that it's global?
* Indicate is -> Indicate if
* java.library.path should use ${snappy.lib} vs ${snappy.prefix}/lib
* #if shoudldn't be indented in org_apache_hadoop_io_compress_snappy.h, and
Snappy*.c, ie everything can be shifted left one stop.
* 1st echo in packageNativeHadoop.sh is missindented
* "io.compression.codec.snappy.buffersize" should be defined in
CommonConfigurationKeys
* In LoadSnappy I don't think we need to log if hadoopNativeAvailable because
that will is indicated by the output of NativeCodeLoader already
> Integrate Snappy compression
> ----------------------------
>
> Key: HADOOP-7206
> URL: https://issues.apache.org/jira/browse/HADOOP-7206
> Project: Hadoop Common
> Issue Type: New Feature
> Affects Versions: 0.21.0
> Reporter: Eli Collins
> Assignee: Alejandro Abdelnur
> Attachments: HADOOP-7206-002.patch, HADOOP-7206.patch,
> HADOOP-7206new.patch, HADOOP-7206revertplusnew-b.patch,
> HADOOP-7206revertplusnew.patch,
> v2-HADOOP-7206-snappy-codec-using-snappy-java.txt,
> v3-HADOOP-7206-snappy-codec-using-snappy-java.txt,
> v4-HADOOP-7206-snappy-codec-using-snappy-java.txt,
> v5-HADOOP-7206-snappy-codec-using-snappy-java.txt
>
>
> Google release Zippy as an open source (APLv2) project called Snappy
> (http://code.google.com/p/snappy). This tracks integrating it into Hadoop.
> {quote}
> Snappy is a compression/decompression library. It does not aim for maximum
> compression, or compatibility with any other compression library; instead, it
> aims for very high speeds and reasonable compression. For instance, compared
> to the fastest mode of zlib, Snappy is an order of magnitude faster for most
> inputs, but the resulting compressed files are anywhere from 20% to 100%
> bigger. On a single core of a Core i7 processor in 64-bit mode, Snappy
> compresses at about 250 MB/sec or more and decompresses at about 500 MB/sec
> or more.
> {quote}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
