elek commented on a change in pull request #561: HDDS-1043. Enable token based
authentication for S3 api.
URL: https://github.com/apache/hadoop/pull/561#discussion_r262962834
##########
File path:
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/S3SecretManager.java
##########
@@ -27,4 +27,10 @@
public interface S3SecretManager {
S3SecretValue getS3Secret(String kerberosID) throws IOException;
+
Review comment:
The two methods are confusing a little. Especially as the bigger part of the
implementation is duplicated. Would be great to merge them (or use better
naming). (Not a blocker, we can address it later).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
