hadoop-yetus commented on issue #569: HDDS-1232 : Recon Container DB service definition. URL: https://github.com/apache/hadoop/pull/569#issuecomment-470730420 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |:----:|----------:|--------:|:--------| | 0 | reexec | 26 | Docker mode activated. | ||| _ Prechecks _ | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 3 new or modified test files. | ||| _ trunk Compile Tests _ | | 0 | mvndep | 25 | Maven dependency ordering for branch | | +1 | mvninstall | 1025 | trunk passed | | +1 | compile | 973 | trunk passed | | +1 | checkstyle | 193 | trunk passed | | +1 | mvnsite | 133 | trunk passed | | +1 | shadedclient | 1046 | branch has no errors when building and testing our client artifacts. | | +1 | findbugs | 169 | trunk passed | | +1 | javadoc | 119 | trunk passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 22 | Maven dependency ordering for patch | | +1 | mvninstall | 96 | the patch passed | | +1 | compile | 941 | the patch passed | | +1 | javac | 941 | the patch passed | | +1 | checkstyle | 187 | the patch passed | | +1 | mvnsite | 103 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | xml | 1 | The patch has no ill-formed XML file. | | +1 | shadedclient | 612 | patch has no errors when building and testing our client artifacts. | | -1 | findbugs | 45 | hadoop-ozone/ozone-recon generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | | +1 | javadoc | 90 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 68 | common in the patch failed. | | +1 | unit | 38 | framework in the patch passed. | | +1 | unit | 34 | ozone-recon in the patch passed. | | +1 | asflicense | 35 | The patch does not generate ASF License warnings. | | | | 6054 | | | Reason | Tests | |-------:|:------| | FindBugs | module:hadoop-ozone/ozone-recon | | | Found reliance on default encoding in org.apache.hadoop.ozone.recon.spi.impl.ContainerDBServiceProviderImpl.getKeyPrefixesForContainer(long):in org.apache.hadoop.ozone.recon.spi.impl.ContainerDBServiceProviderImpl.getKeyPrefixesForContainer(long): new String(byte[]) At ContainerDBServiceProviderImpl.java:[line 120] | | Failed junit tests | hadoop.hdds.security.x509.certificate.client.TestDefaultCertificateClient | | Subsystem | Report/Notes | |----------:|:-------------| | Docker | Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-569/2/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/569 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml | | uname | Linux 773b2c016654 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | personality/hadoop.sh | | git revision | trunk / 1bc282e | | maven | version: Apache Maven 3.3.9 | | Default Java | 1.8.0_191 | | findbugs | v3.1.0-RC1 | | findbugs | https://builds.apache.org/job/hadoop-multibranch/job/PR-569/2/artifact/out/new-findbugs-hadoop-ozone_ozone-recon.html | | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-569/2/artifact/out/patch-unit-hadoop-hdds_common.txt | | Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-569/2/testReport/ | | Max. process+thread count | 412 (vs. ulimit of 5500) | | modules | C: hadoop-hdds/common hadoop-hdds/framework hadoop-ozone/ozone-recon U: . | | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-569/2/console | | Powered by | Apache Yetus 0.9.0 http://yetus.apache.org | This message was automatically generated.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
