[
https://issues.apache.org/jira/browse/HADOOP-16181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16791759#comment-16791759
]
Steve Loughran commented on HADOOP-16181:
-----------------------------------------
LGTM, except for one little detail
bq. Do not log-and-throw Exception. Anti-pattern.
= 0 on this. AT the very least:
# log the exception.toString @ warn
# log the full stack at debug.
why? too much risk that in shutdown code exceptions get caught and swallowed. I
don't want to lose from the logs the very fact that something has gone wrong
and the ability to get more detail on it.
> HadoopExecutors shutdown Cleanup
> --------------------------------
>
> Key: HADOOP-16181
> URL: https://issues.apache.org/jira/browse/HADOOP-16181
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Affects Versions: 3.2.0
> Reporter: David Mollitor
> Assignee: David Mollitor
> Priority: Minor
> Attachments: HADOOP-16181.1.patch
>
>
> # Add method description
> # Add additional logging
> # Do not log-and-throw Exception. Anti-pattern.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
