hadoop-yetus commented on a change in pull request #610: [MAPREDUCE-7193]
Review of CombineFile Code
URL: https://github.com/apache/hadoop/pull/610#discussion_r265811073
##########
File path:
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/input/CombineFileInputFormat.java
##########
@@ -568,17 +568,20 @@ private void addCreatedSplit(List<InputSplit> splitList,
*/
@VisibleForTesting
static class OneFileInfo {
- private long fileSize; // size of the file
- private OneBlockInfo[] blocks; // all blocks in this file
-
- OneFileInfo(FileStatus stat, Configuration conf,
- boolean isSplitable,
- HashMap<String, List<OneBlockInfo>> rackToBlocks,
- HashMap<OneBlockInfo, String[]> blockToNodes,
- HashMap<String, Set<OneBlockInfo>> nodeToBlocks,
- HashMap<String, Set<String>> rackToNodes,
- long maxSize)
- throws IOException {
+
+ /** Size of the file. */
+ private long fileSize;
+
+ /** All blocks in this file. */
+ private OneBlockInfo[] blocks;
Review comment:
whitespace:end of line
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
