[
https://issues.apache.org/jira/browse/HADOOP-16191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
wujinhu updated HADOOP-16191:
-----------------------------
Description:
Returned status of copyFile and copyDirectory are ignored. It's OK most of the
time.
{code:java}
if (srcStatus.isDirectory()) {
copyDirectory(srcPath, dstPath);
} else {
copyFile(srcPath, srcStatus.getLen(), dstPath);
}
return srcPath.equals(dstPath) || delete(srcPath, true);{code}
However, oss fs can not catch errors when rename from one dir to another if the
src dir is being deleted.
Another improvement is logging optimization.
was:
Returned status of copyFile and copyDirectory are ignored. It's OK most of the
time.
{code:java}
if (srcStatus.isDirectory()) {
copyDirectory(srcPath, dstPath);
} else {
copyFile(srcPath, srcStatus.getLen(), dstPath);
}
return srcPath.equals(dstPath) || delete(srcPath, true);{code}
However, oss fs can not catch errors when rename from one dir to another if the
src dir is being deleted.
Another improvement is optimize logging and remove meaningless logs or change
to debug level
> AliyunOSS: improvements for copyFile/copyDirectory and logging
> --------------------------------------------------------------
>
> Key: HADOOP-16191
> URL: https://issues.apache.org/jira/browse/HADOOP-16191
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/oss
> Affects Versions: 2.10.0, 2.9.2, 3.0.3, 3.3.0, 3.1.2
> Reporter: wujinhu
> Assignee: wujinhu
> Priority: Major
> Attachments: HADOOP-16191.001.patch
>
>
> Returned status of copyFile and copyDirectory are ignored. It's OK most of
> the time.
> {code:java}
> if (srcStatus.isDirectory()) {
> copyDirectory(srcPath, dstPath);
> } else {
> copyFile(srcPath, srcStatus.getLen(), dstPath);
> }
>
> return srcPath.equals(dstPath) || delete(srcPath, true);{code}
> However, oss fs can not catch errors when rename from one dir to another if
> the src dir is being deleted.
>
> Another improvement is logging optimization.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
