ajayydv commented on a change in pull request #601: HDDS-1119. DN get OM
certificate from SCM CA for block token validat…
URL: https://github.com/apache/hadoop/pull/601#discussion_r266045854
##########
File path:
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/security/OzoneDelegationTokenSecretManager.java
##########
@@ -90,8 +90,9 @@ public OzoneDelegationTokenSecretManager(OzoneConfiguration
conf,
service, LOG);
currentTokens = new ConcurrentHashMap();
this.tokenRemoverScanInterval = dtRemoverScanInterval;
- this.store = new OzoneSecretStore(conf);
- this.s3SecretManager = s3SecretManager;
+ this.s3SecretManager = (S3SecretManagerImpl) s3SecretManager;
Review comment:
S3SecretManagerImpl has helper function to return OMMetadataManager required
in secret store. Its interface doesn't. Since it is returning a dependency i
think its better to not push it to interface itself.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
