[
https://issues.apache.org/jira/browse/HADOOP-7324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13056638#comment-13056638
]
Luke Lu commented on HADOOP-7324:
---------------------------------
Thanks Priyo, the patch is coming together nicely.
More issues I missed/noticed:
# Breaking the MetricsCache API requires the approval of release manager for
branch-0.20-security. It'd be better if we can keep the existing
MetricsCache#getMetric method intact and add a #getMetricInstance for the
object.
# You can have the abstract sink implement the visitor interface to avoid
creating new instances of the visitor in #putMetrics.
# It'll be nice to have a unit test for these sinks. We can mock the
datagramSocket to capture the packet with mockito.
> Ganglia plugins for metrics v2
> ------------------------------
>
> Key: HADOOP-7324
> URL: https://issues.apache.org/jira/browse/HADOOP-7324
> Project: Hadoop Common
> Issue Type: Bug
> Components: metrics
> Affects Versions: 0.20.203.0, 0.23.0
> Reporter: Luke Lu
> Assignee: Priyo Mustafi
> Priority: Blocker
> Labels: regression
> Fix For: 0.23.0
>
> Attachments: HADOOP-7324.patch, HADOOP-7324.patch
>
>
> Although, all metrics in metrics v2 are exposed via the standard JMX
> mechanisms, most users are using Ganglia to collect metrics.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
