arp7 commented on a change in pull request #620: HDDS-1205. Refactor
ReplicationManager to handle QUASI_CLOSED contain…
URL: https://github.com/apache/hadoop/pull/620#discussion_r266625835
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/SCMContainerManager.java
##########
@@ -131,6 +131,16 @@ public ContainerStateManager getContainerStateManager() {
return containerStateManager;
}
+ @Override
Review comment:
We should not make a copy of the containerID map in
SCMContainerManager#getContainerIDs. This could be quite inefficient when we
have millions of containers. I see an existing function
SCMContainerManager#getContainers just below that one which looks inefficient.
This needs to be fixed too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
