sahilTakiar commented on a change in pull request #600: HDFS-14348: Fix JNI
exception handling issues in libhdfs
URL: https://github.com/apache/hadoop/pull/600#discussion_r267065815
##########
File path:
hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfs/hdfs.c
##########
@@ -2498,6 +2498,11 @@ int hadoopRzOptionsSetByteBufferPool(
return -1;
}
+ if (opts->byteBufferPool) {
+ // Delete any previous ByteBufferPool we had.
+ (*env)->DeleteGlobalRef(env, opts->byteBufferPool);
Review comment:
Done. Fixed a few other issues I found with this method while I was at it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
